Skip to content

[BACKPORT 2025.2][DEVOPS-3735] ci: github actions for PR static check#31528

Open
svarnau wants to merge 11 commits into
yugabyte:2025.2from
svarnau:gh2025.2b
Open

[BACKPORT 2025.2][DEVOPS-3735] ci: github actions for PR static check#31528
svarnau wants to merge 11 commits into
yugabyte:2025.2from
svarnau:gh2025.2b

Conversation

@svarnau
Copy link
Copy Markdown
Member

@svarnau svarnau commented May 8, 2026

Some description

Original commit: 123abc* / #12345

And more info

svarnau and others added 8 commits May 8, 2026 10:50
commit 19b0b6e
Author: Steve Varnau <steve.varnau@yugabyte.com>
Date:   Fri May 8 10:24:43 2026 -0700

    stray quotes

commit aa80494
Author: Steve Varnau <steve.varnau@yugabyte.com>
Date:   Fri May 8 10:20:16 2026 -0700

    add backport title check

commit 5832381
Author: Steve Varnau <steve.varnau@yugabyte.com>
Date:   Fri May 1 14:19:46 2026 -0700

    Revert "testing action"

    This reverts commit b687798.

commit b687798
Author: Steve Varnau <steve.varnau@yugabyte.com>
Date:   Fri May 1 13:50:46 2026 -0700

    testing action

commit 48bab34
Author: Steve Varnau <steve.varnau@yugabyte.com>
Date:   Fri May 1 13:49:53 2026 -0700

    add upgrade check, remove broken actions

commit ee2a297
Author: Steve Varnau <steve.varnau@yugabyte.com>
Date:   Fri May 1 11:12:35 2026 -0700

    fix up docker call

commit 2b77654
Author: Steve Varnau <steve.varnau@yugabyte.com>
Date:   Fri May 1 11:05:21 2026 -0700

    test avoiding chown

commit 41682ab
Author: Steve Varnau <steve.varnau@yugabyte.com>
Date:   Fri May 1 11:02:17 2026 -0700

    Revert "check golint and pep8 linters"

    This reverts commit cd629a6.

commit c0a4dbe
Author: Steve Varnau <steve.varnau@yugabyte.com>
Date:   Fri May 1 10:42:01 2026 -0700

    try as 2 docker steps

commit cd629a6
Author: Steve Varnau <steve.varnau@yugabyte.com>
Date:   Fri May 1 09:54:38 2026 -0700

    check golint and pep8 linters

commit abc46bc
Author: Steve Varnau <steve.varnau@yugabyte.com>
Date:   Fri May 1 09:23:09 2026 -0700

    lint without custom container image

commit 4c505f4
Author: Steve Varnau <steve.varnau@yugabyte.com>
Date:   Fri May 1 09:11:40 2026 -0700

    checkpoint

commit e3a1198
Author: Steve Varnau <steve.varnau@yugabyte.com>
Date:   Thu Apr 30 16:15:21 2026 -0700

    safe dir git config

commit 45c2701
Author: Steve Varnau <steve.varnau@yugabyte.com>
Date:   Thu Apr 30 16:10:30 2026 -0700

    fix quoting in docker script

commit b802db4
Author: Steve Varnau <steve.varnau@yugabyte.com>
Date:   Thu Apr 30 16:04:10 2026 -0700

    debug path

commit 632744a
Author: Steve Varnau <steve.varnau@yugabyte.com>
Date:   Thu Apr 30 15:49:21 2026 -0700

    regex for bash ERE

commit f5bd5ba
Author: Steve Varnau <steve.varnau@yugabyte.com>
Date:   Thu Apr 30 14:23:48 2026 -0700

    ybci user and stray quote

commit 05c64bf
Author: Steve Varnau <steve.varnau@yugabyte.com>
Date:   Thu Apr 30 14:05:47 2026 -0700

    fix docker options

commit 37ce8d3
Author: Steve Varnau <steve.varnau@yugabyte.com>
Date:   Thu Apr 30 13:52:38 2026 -0700

    fix stray quote

commit f8544df
Author: Steve Varnau <steve.varnau@yugabyte.com>
Date:   Thu Apr 30 13:50:50 2026 -0700

     Please enter the commit message for your changes. Lines starting
     moved to workflows

commit d6da17b
Author: Steve Varnau <steve.varnau@yugabyte.com>
Date:   Thu Apr 30 13:50:40 2026 -0700

    move lint action file

commit 4cfd1e4
Author: Steve Varnau <steve.varnau@yugabyte.com>
Date:   Thu Apr 30 13:45:33 2026 -0700

    lint file

commit a7ed90c
Author: Steve Varnau <steve.varnau@yugabyte.com>
Date:   Thu Apr 30 13:45:00 2026 -0700

    lint file

commit 4e29ce1
Author: Steve Varnau <steve.varnau@yugabyte.com>
Date:   Thu Apr 30 13:44:44 2026 -0700

    move lint to separate file to change event triggers

commit efc3b47
Author: Steve Varnau <steve.varnau@yugabyte.com>
Date:   Thu Apr 30 13:20:26 2026 -0700

    reduced lint rule

commit 2e1179a
Author: Steve Varnau <steve.varnau@yugabyte.com>
Date:   Wed Apr 29 16:49:05 2026 -0700

    add PR checks, remove PR builds

commit db30c62
Author: Steve Varnau <steve.varnau@yugabyte.com>
Date:   Tue Apr 28 09:49:50 2026 -0700

    WIP - automation testing
…ider

Summary:
Add access key block to request body only when the fields are present and have valid inputs

Original commit: 839f201 / D52791

Test Plan: Manually test

Reviewers: amalyshev, nsingh

Reviewed By: nsingh

Subscribers: yugaware

Differential Revision: https://phorge.dev.yugabyte.com/D52843
…ash -c drops --input in yb_platform_backup.sh

Summary:
Original diff: https://phorge.dev.yugabyte.com/D52820 (d6eb93e)

 Shell script expansion issue when the array is a part of a longer quoted string.

```
    kubectl -n "${k8s_namespace}" exec -it "${k8s_pod}" -c yugaware -- /bin/bash -c \
            "${backup_script} restore ${restore_args[@]}"
```

got expanded to

```
    kubectl -n yw-ns-jenk-id19549-7b5a150ce1-secondary exec -it yw-ns-jenk-id19549-7b5a150ce1-secondary-yugaware-0 -c yugaware -- /bin/bash -c '/opt/yugabyte/devops/bin/yb_platform_backup.sh restore -v' --input /opt/yugabyte/backup_26-05-06-14-27.tgz --skip_old_files
```

Test Plan:
itest run has confirmed (passed) it.

https://jenkins.dev.yugabyte.com/job/dev-itest-job/35381/artifact/logs/2.13.3.0_testk8sybabackup-k8s-rf3_20260507_085030/testk8sybabackup-k8s-rf3fvbijkhy.log

```

Unable to use a TTY - input is not a terminal or the right kind of file
+ backup_file=backup_26-05-07-09-10.tgz
+ backup_file=backup_26-05-07-09-10.tgz
+ verbose_flag=
+ [[ true == true ]]
+ verbose_flag=-v
+ backup_script=/opt/yugabyte/devops/bin/yb_platform_backup.sh
+ restore_args=(${verbose_flag} --input ${K8S_BACKUP_DIR}/${backup_file} --skip_old_files)
+ [[ false = true ]]
+ [[ false = true ]]
+ cmd=("$backup_script" restore "${restore_args[@]}")
++ printf '%q ' /opt/yugabyte/devops/bin/yb_platform_backup.sh restore -v --input /opt/yugabyte/backup_26-05-07-09-10.tgz --skip_old_files
+ kubectl -n yw-ns-jenk-ci35381-64734e5830-secondary exec -it yw-ns-jenk-ci35381-64734e5830-secondary-yugaware-0 -c yugaware -- /bin/bash -c '/opt/yugabyte/devops/bin/yb_platform_backup.sh restore -v --input /opt/yugabyte/backup_26-05-07-09-10.tgz --skip_old_files '

```

Reviewers: anijhawan, nbhatia, ayush.kushwaha

Reviewed By: ayush.kushwaha

Subscribers: nikhil, yugaware, ayush.kushwaha

Differential Revision: https://phorge.dev.yugabyte.com/D52902
…ong time (> 2 hours) even in 3 node clusters

Summary:
Disabled the redaction for postgres sql logs , as they were causing high cpu usage also
taking lot of time for support bundle creation.
Original Commit : fe9ec80 / D52857

Test Plan:
Manual Testing

Dev Testing Steps:

Setup:

Universe with 3 db nodes
Generated lot of postgres sql logs under ~/tserver/logs for each node
total of 6000+  postgres sql files including all nodes
each file < 5 MB in size

Support Bundles Created

Only Universe Logs:
Complete Support Bundle except prometheus
Time range - last 3 days

Observation:

Before Fix:

Time taken more than 20 min , stuck at 38% for Complete Support Bundle except prometheus  => manually aborted
Same observation for only Universe logs => Manually Aborted
CPU usage => 300%

After Fix :

Time taken more than < 3 min
Complete Support Bundle : 296 MB
Only Universe Logs : 294 MB

CPU usage => 120%

Reviewers: vkumar, vbansal, aaryan.chauhan, anijhawan

Reviewed By: vbansal, aaryan.chauhan

Subscribers: yugaware, agunta, agarg

Differential Revision: https://phorge.dev.yugabyte.com/D52876
…_lsn is greater than last_seen_lsn

Summary:
#### Backport Description
No merge conflicts were encountered.

#### Original Description

##### Code changes summary
When the walsender receives a` confirmed_flush_lsn` as an acknowledgement, it sends `restart_lsn`, calculated as `confirmed_flush_lsn + 1` to the virtual WAL. The VWAL has a mechanism to move the restart time forward when there is nothing left to stream. To detect that there is nothing more left to stream, it compares the `restart_lsn` with the `last_seen_lsn` (the last lsn generated for a record by VWAL). If they are equal, restart time is moved forward.

However, since walsender increments `restart_lsn`, the equality condition would never be true. As a result, the mechanism of moving restart time forward did not work. This diff fixes this issue by changing the equality check to a greater than equal to check.

##### Considerations for colocated tables
NA

##### Upgrade and rollback considerations
NA

##### Considerations for connector
NA

Original commit: 9202b63 / D52037

Test Plan:
New test, this brings walsender into the test's scope:
  - ./yb_build.sh --java-test 'org.yb.pgsql.TestPgReplicationSlot#testRestartTimeMovementWithNoWorkload'

Modified an existing test:
  - ./yb_build.sh --cxx-test integration-tests_cdcsdk_consumption_consistent_changes-test --gtest_filter CDCSDKConsumptionConsistentChangesTest.TestMovingRestartTimeForwardWhenNothingToStream

Reviewers: #db-approvers, skumar, asrinivasan, devansh.singhal

Reviewed By: devansh.singhal

Subscribers: svc_phabricator, ycdcxcluster

Tags: #jenkins-ready

Differential Revision: https://phorge.dev.yugabyte.com/D52850
…nd the correct payload for useRoles or cron-based schedules

Summary: Backport of this [[ https://phorge.dev.yugabyte.com/D52693 | diff ]]

Test Plan: Tested manually

Reviewers: lsangappa

Reviewed By: lsangappa

Subscribers: yugaware

Differential Revision: https://phorge.dev.yugabyte.com/D52887
@CLAassistant
Copy link
Copy Markdown

CLAassistant commented May 8, 2026

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
3 out of 6 committers have signed the CLA.

✅ Sumukh-Phalgaonkar
✅ svarnau
✅ haikarthikssk
❌ Deepti-yb
❌ nkhogen
❌ rajivkumar-dev
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces an intentional build failure in the Jenkins build script by adding an exit command. The review feedback correctly identifies this as debug code that must be removed before merging to prevent blocking the build process.

Comment on lines +42 to +44
echo "Intentional build failure"
exit 1

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

The intentional build failure and exit command will prevent the script from executing. This code appears to be for testing purposes and should be removed before merging this pull request.

@svarnau svarnau changed the title [2025.2][DEVOPS-3735] ci: github actions for PR static check [BACKPORT 2025.2][DEVOPS-3735] ci: github actions for PR static check May 8, 2026
@svarnau svarnau changed the title [BACKPORT 2025.2][DEVOPS-3735] ci: github actions for PR static check [BACKPORT 2025.1][DEVOPS-3735] ci: github actions for PR static check May 8, 2026
@svarnau svarnau changed the title [BACKPORT 2025.1][DEVOPS-3735] ci: github actions for PR static check [BACKPORT 2025.2][DEVOPS-3735] ci: github actions for PR static check May 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants